search

airblade / vim-gitgutter

A Vim plugin which shows git diff markers in the sign column and stages/previews/undoes hunks and partial hunks.
MIT License
8.37k stars 297 forks source link

errors when file path includes colons #877

Closed vais closed 10 months ago

vais commented 10 months ago

What is the latest commit SHA in your installed vim-gitgutter? 4b49965897b8264cd6f90fa47ddb917f4296c469 What vim/nvim version are you on? 9.0.1897

I believe this commit introduced a regression whereby paths containing : result in errors being displayed every time a buffer is loaded/activated https://github.com/airblade/vim-gitgutter/commit/952dbc34f78341ce4c4e68a11a1b472c270a369b

Specifically I think this line's the culprit: https://github.com/airblade/vim-gitgutter/commit/952dbc34f78341ce4c4e68a11a1b472c270a369b#diff-8ca6e89485ffd459c09d6c5d99568d0784d6792b50f317daea59cb1ad7accebbR246

vais commented 10 months ago

To repro, simply make a directory in your repo that has a colon somewhere in its name.

airblade commented 10 months ago

I'm sure you're right. I'll fix this up in the next few days when I get a chance.

vais commented 10 months ago

I'm sure you're right. I'll fix this up in the next few days when I get a chance.

You're awesome, thank you!