airblade / voom

A simplest-thing-that-works Vim plugin manager. Use with Vim 8 or Pathogen.
MIT License
29 stars 9 forks source link

Fix: uninstall_plugin: substring match #21

Closed dezza closed 2 years ago

dezza commented 2 years ago

:) Its the other way this time (hah).

If you had ~/src/vim/lsp before

and now remove/comment that out

~/src/vim/lsp-test matches 🤦‍♂️ no plugin is removed.

airblade commented 2 years ago

Thanks! I can't believe I didn't think of that before ;)

dezza commented 2 years ago

I'm still enjoying it everyday! I started using gitgutter too..

the vim-matchquote could be better! we talked briefly on #vim about it. somewhere vim has knowledge about quote-matching in the syntax files cuz it gets it right!

airblade commented 2 years ago

I'm still enjoying it everyday! I started using gitgutter too..

I'll look forward to some pull requests there :)

the vim-matchquote could be better! we talked briefly on #vim about it. somewhere vim has knowledge about quote-matching in the syntax files cuz it gets it right!

That's interesting to hear. Is there a link somewhere to the conversation? I really think vim should be doing it already, especially if it kind-of already is with the syntax files.

dezza commented 2 years ago

I don't mind sharing it.

[2022-10-13T22:44:18.089Z] <m_ben> technically, we have the information where a single/double quote starts and ends in a buffer: the internal syntax engine knows it, we just don't have access to it
[2022-10-13T22:47:25.146Z] <dza> m_ben: nickspoon: It would be so awesome if we could get it
[2022-10-13T22:48:23.150Z] <m_ben> dza: there's a very large issue that discusses improving vim's syntax engine, maybe you could mention it there
[2022-10-13T22:48:55.138Z] <nickspoon> I wonder if something like the PrepareTypeHierarchy and TypeHierarchySuperTypes endpoints would work? https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareTypeHierarchy
[2022-10-13T22:49:19.511Z] <m_ben> tree sitter exposes the entire AST doesn't it
[2022-10-13T22:49:37.844Z] <nickspoon> that's my understanding but I haven't ever used it
[2022-10-13T22:50:22.244Z] <m_ben> isn't the LSP type hierarchy thing about class-subclass relations?
[2022-10-13T22:50:31.577Z] <nickspoon> I prefer the idea of some sort of vim API that plugins can access for advanced syntax highlighting. It was sort of proposed in that big github issue but there's too much noise in there, the signals are all lost I think
[2022-10-13T22:50:49.272Z] <nickspoon> m_ben: I don't know, trying to guess from endpoint names
[2022-10-13T22:51:18.439Z] <nickspoon> You might be right
[2022-10-13T22:51:38.722Z] <nickspoon> But LSP does also have an AST so the question is, can it be directly accessed according to the spec?
[2022-10-13T22:52:08.953Z] <m_ben> I find the current syntax commands extremely unintuitive
[2022-10-13T22:52:20.721Z] <nickspoon> The current vim syntax highlight?
[2022-10-13T22:52:24.945Z] <m_ben> yes
[2022-10-13T22:52:28.755Z] <nickspoon> Yeah they are a bit messy
[2022-10-13T22:52:48.028Z] <nickspoon> So a nice api to replace them and allow plugging other things in tidily would be great
[2022-10-13T22:53:23.936Z] <nickspoon> You can syntax highlight from a language server with text properties (I've done it) but it's also a bit slow and clunky.
[2022-10-13T22:53:34.358Z] <nickspoon> Vim providing a proper recommended way to do it would be fantastic
[2022-10-13T22:53:53.674Z] <nickspoon> And more flexible than just including treesitter or textmate grammar or whatever
[2022-10-13T22:54:20.351Z] <dza> donate to vim vote syntax :)
[2022-10-13T22:54:43.871Z] <nickspoon> :+1:
[2022-10-13T22:54:59.410Z] <m_ben> I really don't see how textmate grammar improves anything. does it really? and I still haven't seen anyone explain textmate in that giant issue
[2022-10-13T22:55:06.035Z] <nickspoon> I don't think so
[2022-10-13T22:55:42.674Z] <nickspoon> But if people want to use it, a tidy plugin api would allow it
[2022-10-13T22:56:02.962Z] <m_ben> tree sitter on the other hand is more accurate and allows you to write accurate %, ]], ]m, ]M etc mappings
[2022-10-13T22:57:21.185Z] <nickspoon> I just don't think it needs to be built in. I don't want treesitter running when I have a language server giving *better* highlighting and navigation. But it would be nice to be able to fall back to a treesitter plugin if i wanted
[2022-10-13T22:57:31.085Z] <dza> where is the issue we should read?
[2022-10-13T22:57:37.610Z] <nickspoon> Anyway I'm not implementing it so :shrug:
[2022-10-13T22:58:06.518Z] <m_ben> dza: https://github.com/vim/vim/issues/9087

You should come in sometime :) people are quite nice and its a huge channel.

airblade commented 2 years ago

Thank you!