search

airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.38k stars 407 forks source link

DeepLinkProcessor overrides previous intent flags #198

Open danilolapegna opened 7 years ago

danilolapegna commented 7 years ago

I can see that the DeepLinkProcessor file has in its code, line 527:

.addStatement("newIntent.setFlags(Intent.FLAG_ACTIVITY_FORWARD_RESULT)")

Shouldn't it be "addFlags" instead of "setFlags"? The setFlags overrides any other flag I could have previously added to an intent created in @DeepLink annotated method (ex. Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_SINGLE_TOP, etc.) and this may cause navigation issues, or anyway override the navigation behaviour I've thought for a specific deep link (ex. I want an activity ran via deep link to start a new task and clear previous ones. Right now I can't).

Thanks

HarisHoulis commented 4 years ago

This issue still occurs. Any news?