search

airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.38k stars 405 forks source link

Add android-maven plugin #230

Closed rogerhu closed 5 years ago

rogerhu commented 6 years ago

See: https://github.com/jitpack/jitpack.io/blob/master/ANDROID.md

From what I can tell this allows JetPack.io to find the repo:

https://jitpack.io/com/github/rogerhu/DeepLinkDispatch/maven-v3.1.1-g34b4e9c-11/build.log

Build artifacts:
com.github.rogerhu.DeepLinkDispatch:deeplinkdispatch:maven-v3.1.1-g34b4e9c-11
com.github.rogerhu.DeepLinkDispatch:deeplinkdispatch-processor:maven-v3.1.1-g34b4e9c-11
com.github.rogerhu.DeepLinkDispatch:deeplinkdispatch-base:maven-v3.1.1-g34b4e9c-11

Interestingly the maven-v3.1.1 seems to be the last tagged release, the g34b4e9c is the commit hash, and 11 marks the # of commits since the tag.

rogerhu commented 6 years ago

Secondly, given the Nexus plugin has been deprecated (https://github.com/bmuschko/gradle-nexus-plugin), does it make sense to remove?

rogerhu commented 6 years ago

See this issue reported to Google -- https://issuetracker.google.com/issues/116745353 -> Google has concluded there is no way to use this lib when JetIfier is turned on without updating to the latest. So having a way for people to test with AndroidX using this pull request would greatly help....

rogerhu commented 6 years ago

Ping on this one!

rogerhu commented 5 years ago

Anyone around? :)

Google will now start to die for libraries that it cannot resolve with Jetifier: https://issuetracker.google.com/issues/116745353

rogerhu commented 5 years ago

Hello? :)

felipecsl commented 5 years ago

thanks @rogerhu! we'll cut a new release once this is verified stable

rogerhu commented 5 years ago

Thanks @felipecsl!

rogerhu commented 5 years ago

I would tag and release. It's been 18 days now and pointing it to the new Jitpack seems fine for me. Anyone else?

felipecsl commented 5 years ago

once this is tested internally at Airbnb we should be fine to release a new version, cc @rossbacher for visibility

radityagumay commented 5 years ago

@felipecsl when release date for this version?

AnwarShahriar commented 5 years ago

@felipecsl is there any tentative date for the release?

Crysis21 commented 5 years ago

hey guys, it's been months already.

calvinnor commented 5 years ago

I've gone ahead and used the Snapshot versions on production. Haven't faced any issues yet.

To note: most stable software is just an alpha with a tag. Use it and report if you find bugs. Else, it's good to go.

felipecsl commented 5 years ago

sorry y'all I don't at Airbnb anymore so I don't have visibility on their release schedule anymore. Either way, I'd be happy to cut a new release if folks are okay with that cc @rossbacher @BenSchwab

rossbacher commented 5 years ago

I’m on it. Sometime next week, just some setup required. But I’m almost done with everything. So don’t worry Felipe. But thank you!

On Jan 26, 2019, at 13:32, Felipe Lima notifications@github.com wrote:

sorry y'all I don't at Airbnb anymore so I don't have visibility on their release schedule anymore. Either way, I'd be happy to cut a new release if folks are okay with that cc @rossbacher @BenSchwab

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rossbacher commented 5 years ago

4.0.0 is out now https://github.com/airbnb/DeepLinkDispatch/releases/tag/4.0.0 though I had to revert this change to get it working. Let me know if you still have any issues.

rossbacher commented 5 years ago

4.0.0 was sadly borked. Please use 4.1.0 instead: https://github.com/airbnb/DeepLinkDispatch/releases/tag/v4.1.0