search

airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.37k stars 407 forks source link

Issues upgrading to v4.0.0 #243

Closed bblia closed 5 years ago

bblia commented 5 years ago

Trying to update to v4.0.0 based on https://github.com/airbnb/DeepLinkDispatch/issues/222#issuecomment-458737266

but getting the below exceptions causing gradle sync to fail:

image

felipecsl commented 5 years ago

did you forget to add mavenCentral() to your gradle dependencies? I can see the archives there already http://repo1.maven.org/maven2/com/airbnb/deeplinkdispatch/4.0.0/

rossbacher commented 5 years ago

I didn't anticipate how long the sync can take and published the release on github a bit prematurely. It should all be good now.

rossbacher commented 5 years ago

Actually I see there is a problem with the release. :-( Investigating right now.

bblia commented 5 years ago

image

bblia commented 5 years ago

Appreciate it -- thank you!

rossbacher commented 5 years ago

I found the problem. 4.1.0 is coming. Sorry for that.

rossbacher commented 5 years ago

Fixed with https://github.com/airbnb/DeepLinkDispatch/pull/244

rossbacher commented 5 years ago

4.1.0-SNAPSHOT is already available and I verified the fix. I just published 4.1.0 but it might take a while until it is synced to central.

ron-steiner commented 5 years ago

spot on @bblia

bblia commented 5 years ago

Still not seeing it but i'll wait a while longer -- I shouldn't need mavenCentral() if i have jCenter() right?

rossbacher commented 5 years ago

I just build our app with it

Still not seeing it but i'll wait a while longer -- I shouldn't need mavenCentral() if i have jCenter() right?

I just build with it right now. And it is here: https://repo1.maven.org/maven2/com/airbnb/deeplinkdispatch/

bblia commented 5 years ago

YAY it works here now as well. Thank you very much @rossbacher !!