search

airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.37k stars 407 forks source link

Documentation: AppDeepLinkModuleLoader instead of AppDeepLinkModuleRegistry #278

Closed igorkovalchuk closed 4 years ago

igorkovalchuk commented 4 years ago

DeepLinkDispatch version: 4.1.0

Today in the documentation you have:

/** This will generate a AppDeepLinkModuleRegistry class */
@DeepLinkModule
public class AppDeepLinkModule {
}

I was confused because I got a compilation error here:

DeepLinkDelegate deepLinkDelegate = 
        new DeepLinkDelegate(new AppDeepLinkModuleRegistry());

It can't find the AppDeepLinkModuleRegistry. I've discovered that I should use a AppDeepLinkModuleLoader (generated class) instead. Do you have a mistype in the documentation?

Thank you!

rossbacher commented 4 years ago

Possibly it should all be Registries now as we renamed that and made the naming moire clear in 4.0. Let me check that on Monday and fix if necessary.

rossbacher commented 4 years ago

Also are you sure you are using 4.x of both dependencies the lib and the processor? If you mix them that could also happen.

rossbacher commented 4 years ago

I did check and we don't have any Loader code left over. (e.g. see our own sample https://github.com/airbnb/DeepLinkDispatch/blob/master/sample/src/main/java/com/airbnb/deeplinkdispatch/sample/DeepLinkActivity.java#L18).

I'm closing this as you must be using old and or mixed dependencies.

rossbacher commented 4 years ago

Sorry when I said 4.x I meant 5.x.