airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.37k stars 407 forks source link

cannot find symbol: symbol: class SampleModuleLoader #279

Closed asshyy-ktz closed 4 years ago

asshyy-ktz commented 4 years ago

cannot find symbol DeepLinkDelegate deepLinkDelegate = new DeepLinkDelegate(new SampleModuleLoader(), new LibraryDeepLinkModuleLoader()); ^ symbol: class SampleModuleLoader location: class DeepLinkActivity

import com.airbnb.deeplinkdispatch.DeepLinkHandler;

@DeepLinkHandler({SampleModule.class, LibraryDeepLinkModule.class}) public class DeepLinkActivity extends Activity { @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); DeepLinkDelegate deepLinkDelegate = new DeepLinkDelegate(new SampleModuleLoader(), new LibraryDeepLinkModuleLoader()); deepLinkDelegate.dispatchFrom(this); finish(); } }

after generating DeepLinkDelegate successfully. I'm unable to generate SampleModuleLoader() class. using 5.1.0 lib.

linnar commented 4 years ago

The generated classes now end with Registry instead of Loader, so you should import and use SampleModuleRegistry and LibraryDeepLinkModuleRegistry. I think this should be noted in documentation, I was also confused.

rossbacher commented 4 years ago

the documentation was updated. Can you link me to the part that is confusing?

linnar commented 4 years ago

The documentation is good for new users and the place where I noticed the change, but I think it would be nice to have a mention of the renaming in the changelog or section for upgrading 4.x to 5.x in the readme.

rossbacher commented 4 years ago

https://github.com/airbnb/DeepLinkDispatch/pull/281