airbnb / DeepLinkDispatch

A simple, annotation-based library for making deep link handling better on Android
http://nerds.airbnb.com/deeplinkdispatch/
4.38k stars 406 forks source link

Performance issue in chunkOnModifiedUtf8ByteSize #350

Open rciovati opened 2 years ago

rciovati commented 2 years ago

While debugging some built time issues in our codebase I noticed that DeepLinkProcessor takes a suspiciously high amount of time (in our case 3x than Dagger). I grabbed a trace with YourKit and, if I'm reading it correctly, the processor is spending most of its time in chunkOnModifiedUtf8ByteSize.

Screen Shot 2022-06-24 at 13 38 19

Screen Shot 2022-06-24 at 13 45 03

We're not using ksp yet but it seems to me that this code path is shared between the apt and ksp so I suspect the issue exists there too.