search

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle
Apache License 2.0
693 stars 44 forks source link

Adds Android module and GroupLifecycleManager #10

Closed felipecsl closed 8 years ago

felipecsl commented 8 years ago

This adds an extra module called rxgroups-android and is an Android library. It's aimed and reducing the boilerplate in integrating RxGroups into Android apps by doing most of the repetitive work for you. Still a work in progress, will update the Sample app to use this instead

@elihart /cc @airbnb/android

elihart commented 8 years ago

Generally lgtm as it's basically the same stuff as before. We need to add good docs, which I can help with. We should also reevaluate all the lifecycle steps to make sure they make sense and are flexible so we don't lock ourselves into something that turn out to be bad down the line.

Can probably merge this and then iterate

felipecsl commented 8 years ago

@elihart just updated this, can you please take another look?

elihart commented 8 years ago

lgtm!