Fixes GroupLifecycleManager crash when app is BGed

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle

Apache License 2.0

693 stars 44 forks source link

Fixes GroupLifecycleManager crash when app is BGed #18

Closed felipecsl closed 8 years ago

felipecsl commented 8 years ago

Please review @seanabraham @elihart

elihart commented 8 years ago

Talked in person, silently swallowing a destroyed group error seems dangerous.

Notes: We can get rid of hash code as an identifier and generate a UUID for each ObservableManager and expose it with a getter. Save that UUID in the lifecycle manager state and compare it on every create to see when the manager was recreated.

felipecsl commented 8 years ago

@elihart updated! PTAL

elihart commented 8 years ago

UUID fix lgtm, just some clarification suggestions for the comments