search

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle
Apache License 2.0
693 stars 44 forks source link

Tentative fix for Activity recreated after finish #21

Closed felipecsl closed 8 years ago

felipecsl commented 8 years ago

In some situations it seems like an Activity can be recreated even though its isFinishing() property is set to true. Sounds like we can also check isChangingConfigurations() to make sure it's safe to destroy the group.

@elihart

elihart commented 8 years ago

lgtm but leave a comment about why isFinishing is not enough. even we won't remember in a while why we had to add this :P