search

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle
Apache License 2.0
695 stars 44 forks source link

RxJava2? #34

Open sgrekov opened 7 years ago

sgrekov commented 7 years ago

Hi! Do you have any plans for migrating or any guides for using it with RxJava2? Since RxJava2 released 3 months ago, I think it soon will be a major blocker for using this library.

felipecsl commented 7 years ago

Now that Retrofit 2.2.0 is out with first party support for RxJava 2, I think we can finally upgrade. So yes, this should happen soon!

sgrekov commented 7 years ago

Cool! Thanks!

rahulrj commented 7 years ago

Hi @felipecsl i am working on migrating this library to RxJava2. Do you want to give any suggestions/ pointers for it?

elihart commented 7 years ago

@BenSchwab started work on the RxJava2 migration I believe.

elihart commented 7 years ago

There is quite a lot of new work in the 1.0 branch and the migration will probably happen there. not sure if it is worth making changes to master at this point.

BenSchwab commented 7 years ago

Yes, working on a RxJava2 migration now. I would prefer to keep the changes in the 1.0 branch. If you have started to think about the migration, would appreciate your feedback when I put up the PR @rahulrj

rahulrj commented 7 years ago

@BenSchwab how is the code in master branch different from the 1.0 branch? Is 1.0 the active development branch and will it eventually get merged to master?

BenSchwab commented 7 years ago

Yep, 1.0 is the active development branch for the time being, with experimental features like annotation process based tagging - and now RxJava2. We are testing internally (and the branch may experience API churn) before elevating to a general 1.0 release.

rahulrj commented 6 years ago

Okay @BenSchwab . I was also working parallely on the RxJava2 migration. But i converted the code of the master branch. Because the name 1.0 looked like that might be some old 1.0 release.

meierjan commented 6 years ago

any updates here? :)

[edit]

and can you maybe publish alpha2 so that one can test as well?

JEuler commented 6 years ago

Hi! Any updates for rxjava 2.0 support?