search

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle
Apache License 2.0
693 stars 44 forks source link

Minimum SDK version 16 Reason #35

Closed xstherrera1987 closed 7 years ago

xstherrera1987 commented 7 years ago

Why is the minimum SDK version set to 16?

Being unfamiliar with the RxGroups codebase, I've scanned JellyBean Platform Wikipedia and API 16 Diff Report for clues but nothing stands out as obvious. Can I ignore this ?

eg: <uses-sdk tools:overrideLibrary="com.airbnb.rxgroups.android" />

felipecsl commented 7 years ago

This is the same minSdk that the Airbnb app uses, so that's probably why. I don't think there's a specific reason for that,we should be able to use a lower sdk version if we're not using any 16+ APIs

xstherrera1987 commented 7 years ago

the oldest SDK that Robolectric emulates is API-16. Android Studio reports that this covers ~95.2% of active devices, Android Dashboards claims 98% over a rolling 7-day period. So API 16 seems like a reasonable lower bound, though I did override the minSDK version and run successfully on SDK 15.

felipecsl commented 7 years ago

Should be probably safe to override this to 15 if you want, as described above.