Merge 1.0 alpha branch - Githubissues

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle

Apache License 2.0

693 stars 44 forks source link

Merge 1.0 alpha branch #46

Closed BenSchwab closed 6 years ago

BenSchwab commented 6 years ago

1.0-alpha has worked internally for a few months now

Currently it only has support for Observable types -- no Completable, Flowable, Single, etc yet, which I think would be necessary for a solid 1.0 release.

Seems a little premature to call it 1.0.0-alpha but seems important to bump the major version as this is very much a breaking change.

https://github.com/airbnb/RxGroups/issues/34

@felipecsl @elihart

BenSchwab commented 6 years ago

Some other thoughts before 1.0:

It might also be nice to add LifecycleObserver adapter so RxGroup lifecycle methods don't need to be manually called.
Also a kotlin extension could probably be used to avoid the code generation via a pattern similar to kotterknife

meierjan commented 6 years ago

Can you publish it somewhere? It's currently very inconvenient to test. Would be very happy!

BenSchwab commented 6 years ago

@meierjan 1.0.0-alpha2 has been uploaded.

Again, this is a pretty rough version of what a full 1.0.0 release would look like, so use with caution.