search

airbnb / RxGroups

Easily group RxJava Observables together and tie them to your Android Activity lifecycle
Apache License 2.0
693 stars 44 forks source link

Completable interface added #50

Closed JEuler closed 5 years ago

JEuler commented 6 years ago

Due to the fact that RxJava 2.0 throws exception if faces null values, we need to use Completable. This commit add's CompletableTaggedObserver useful for the API DELETE, REMOVE methods.

BenSchwab commented 6 years ago

I believe you need to update ProcessorUtils and ResubscriptionProcessor to be aware of this new type

JEuler commented 6 years ago

Hm, I'm tested and all worked well without this. But will have a look, thank you.

JEuler commented 6 years ago

Hey there, I've updated the suggested classes.

JEuler commented 6 years ago

Hm, sorry, didnot run the tests. Will take a look and try to fix the problems.

JEuler commented 5 years ago

Not going to update this, so will close.