search

airbnb / Showkase

🔦 Showkase is an annotation-processor based Android library that helps you organize, discover, search and visualize Jetpack Compose UI elements
https://medium.com/airbnb-engineering/introducing-showkase-a-library-to-organize-discover-and-visualize-your-jetpack-compose-elements-d5c34ef01095
Apache License 2.0
2.11k stars 107 forks source link

Bump compose compiler to 1.3.1 and libs to 1.2.1 #253

Closed oas004 closed 1 year ago

oas004 commented 2 years ago

In this PR I have bumped the Compose compiler version to 1.3.0 and the libs to 1.2.1 as the latest stable version 😄

This also meant I had to bump the following:

oas004 commented 1 year ago

I guess 1.3.1 is out now? 🤔 @vinaygaba Should I close this or should I try to update to 1.3.1? Wdyt? :)

vinaygaba commented 1 year ago

Maybe do it in this PR itself @oas004. Since they both support the same version of kotlin, it should be fine to use the latest one. I hadn't merged this before because I wanted to do a release first (which we already did last month) to make sure people using the older version of Kotlin had a version of Showkase that would work. I think going forward, it's compatible regardless so should be easier for us to do this version bumps

oas004 commented 1 year ago

Maybe do it in this PR itself @oas004. Since they both support the same version of kotlin, it should be fine to use the latest one. I hadn't merged this before because I wanted to do a release first (which we already did last month) to make sure people using the older version of Kotlin had a version of Showkase that would work. I think going forward, it's compatible regardless so should be easier for us to do this version bumps

Aha yes that makes sense! I will try to update this PR then 😄

oas004 commented 1 year ago

@vinaygaba Bumped to target 1.3.1 now :) Tests seems fine and seems fine locally :)