search

airbnb / Showkase

🔦 Showkase is an annotation-processor based Android library that helps you organize, discover, search and visualize Jetpack Compose UI elements
https://medium.com/airbnb-engineering/introducing-showkase-a-library-to-organize-discover-and-visualize-your-jetpack-compose-elements-d5c34ef01095
Apache License 2.0
2.11k stars 107 forks source link

Fix bug in getShowkaseMetadataFromPreview where the preview width was being set as the showkase metadata height #280

Closed stefankram closed 1 year ago

stefankram commented 1 year ago

This PR contains a fix for an issue I discovered when trying to get the height information of a @Preview from a ShowkaseBrowserComponent.

Please let me know if I need to add any other tests to get this merged.

vinaygaba commented 1 year ago

@stefankram seems like some tests are failing. Will you do a pass and fix them 🙏

stefankram commented 1 year ago

@vinaygaba yep will take a look!

stefankram commented 1 year ago

@vinaygaba this should be good to re-test

stefankram commented 1 year ago

Hey @vinaygaba I noticed a new version was created. I was hoping to get this PR merged and into that release...

Is there anything else I can help with to get this merged down?

vinaygaba commented 1 year ago

@stefankram about to merge this! Just re-running the build