search

airbnb / Showkase

🔦 Showkase is an annotation-processor based Android library that helps you organize, discover, search and visualize Jetpack Compose UI elements
https://medium.com/airbnb-engineering/introducing-showkase-a-library-to-organize-discover-and-visualize-your-jetpack-compose-elements-d5c34ef01095
Apache License 2.0
2.1k stars 107 forks source link

Set update processor test output flag to false #300

Closed oas004 closed 1 year ago

oas004 commented 1 year ago

Noticed this when working on adding processor tests to custom preview annotation feature that this flag was set to true.

I might be mistaken here, but I think this will then generate the output for all the tests and not actually verify the test themself. Might have been a miss in a feature or something.

I think also it can be a bit mind bothering for people coming into the project to see that their test output is updating every time they run the test without taking the action to actually set the flag locally themself.

However, if you don't agree, feel free to close this PR.

oas004 commented 1 year ago

Is the tests a bit flaky maybe? I ran the tests locally and they passed there. I don't think enabling this should have any effect on the ui, only the the unitTest scope.

vinaygaba commented 1 year ago

@oas004 It's been flaky and I can't tell why. It's mostly been emulator flakiness but maybe there is a way to fix it 🤔

oas004 commented 1 year ago

From the last failure, it says that it can't apply the KSP plugin for the version 1.7.10-1.0.6, but only for api 29 🤔 That is a bit strange.

oas004 commented 1 year ago

Rebasing with latest master ☝️

oas004 commented 1 year ago

@vinaygaba Added this functionality in #303 as well, so whatever gets merged first of these. I can close this as well if that is better. Wdyt? :)

vinaygaba commented 1 year ago

@oas004 I merged this PR!

oas004 commented 1 year ago

Sweet! Will rebase the #303 then :)