search

airbnb / Showkase

🔦 Showkase is an annotation-processor based Android library that helps you organize, discover, search and visualize Jetpack Compose UI elements
https://medium.com/airbnb-engineering/introducing-showkase-a-library-to-organize-discover-and-visualize-your-jetpack-compose-elements-d5c34ef01095
Apache License 2.0
2.1k stars 107 forks source link

Custom MutliPreview annotations don't respect skipPrivatePreviews #312

Closed undermark5 closed 1 year ago

undermark5 commented 1 year ago

Issue #233 and associated resolution PR #303 fail to properly handle MultiPreview annotations.

While trying to configure this in my project, I have a few custom multi preview annotations that are added to some private functions. The KSP step complains stating that the methods can't be private and that if I want it to skip them, I must configure the ksp arguments, which I have done, so the message is actually in error and the multipreview on private methods should be skipped.

oas004 commented 1 year ago

Thanks for the report! I tested it out now, and I can reproduce it. Will try to fix it as fast as possible.

jd565 commented 1 year ago

@oas004 Any idea when this will get into a release? We are hit this problem when updating to beta 18 and it causes an error in ksp and the build fails.

oas004 commented 1 year ago

@jd565 I think that will be up to @vinaygaba and Airbnb when they will release a new version :)

SumeraMartin commented 1 year ago

@vinaygaba Hi, since this is merged, are you planning to release new version? I would be very happy since this is something that is blocking me currently in my project 🙏