search

airbnb / Showkase

🔦 Showkase is an annotation-processor based Android library that helps you organize, discover, search and visualize Jetpack Compose UI elements
https://medium.com/airbnb-engineering/introducing-showkase-a-library-to-organize-discover-and-visualize-your-jetpack-compose-elements-d5c34ef01095
Apache License 2.0
2.1k stars 107 forks source link

ShowkaseBrowserActivity does not open Components/Colors/Typography #314

Open dostalleos opened 1 year ago

dostalleos commented 1 year ago

I'm using Showkase.getBrowserIntent(context) to start the browser activity with my previews. It starts and shows the options (Components, Colors, and Typography) correctly.

But if click on any option, only the AppBar changes its title, but the content stays the same. Please check the screenshots below.

It used to work without any issues. Unfortunately, I don't know when it started. I think that it's not caused by any Showkase SDK update. I suspect Compose SDK.

Showkase version: 1.0.0-beta18 Compose version: 1.4.0

image image image

oas004 commented 1 year ago

Hi, thanks for the report! Is this maybe the same issue as this? https://github.com/airbnb/Showkase/issues/310

dostalleos commented 1 year ago

Yeah, it looks similar. But I'm not experiencing any crashes.

I'm using the following dependencies (latest stable versions): Compose navigation v2.5.3 Accompanist Navigation v0.30.0

It works with Accompanist Navigation v0.28.0.

Are you planning to update the SDK to work with the latest stable versions?

oas004 commented 1 year ago

Hm, It looked very similar at least 🤔

For updating, I think we should bump some of the versions. Maybe we should configure renovate to do it more effortlessly :) Wdyt @vinaygaba ? :)

dostalleos commented 1 year ago

It works again with accompanist navigation v0.30.1.

SohelMNumerator commented 1 year ago

It works again with accompanist navigation v0.30.1.

For me, this didn't work. @oas004 Any other suggestions?

joselamar commented 1 year ago

Experiencing same behaviour