Open bingningO opened 5 months ago
In the context of Showkase, it doesn't quite make sense to parse the device
property because the Showkase browser runs on a physical device. It already supports widthDp
and heightDp
- https://github.com/airbnb/Showkase?tab=readme-ov-file#showkasecomposable-currently-supports-the-following-properties
Thanks for flagging @PreviewScreenSizes
and @PreviewFontScale
. I'll figure out how to best integrate them.
seems Showkase not take screenshots depending on the configuration of @Preview parameter, such as
device
,widthDp
,heightDp
.currently I see if having a @Preview function set as
the generated ShowKaseBrowserComponent looks like below
not read
device
parameter, also not take screenshots depending on its configuration.p.s.
also if ShowKase adds support for new compose @Preview annotations such as
@PreviewScreenSizes
,@PreviewFontScale
, would be much more helpful.