Closed forivall closed 1 year ago
@forivall note how https://github.com/airbnb/babel-plugin-inline-react-svg/pull/77#issuecomment-856833786 explicitly says "not a PR"? This doesn't get things moving, it creates a permanent stain on the repo, and the only way to mitigate that is for me to now maintain two PRs in sync - meaning, please never close this one or delete the branch or repo.
Sorry, I missed that in the comment thread, just skimmed it, and when I used the compare tool in GitHub, it gave a tempting "create a pull request" button, so I clicked it. Sorry again.
Hi @ljharb
Anything I can help with to get this or the one in the last comment of #77 get merged?
@rdhlb no, at this point there's nothing that can be done to help; it'll just take time.
@forivall can you please check the "allow edits" box on the RHS of the PR?
Checkbox isn't there for me. @briganti, is it there for you? Or maybe you'd have to give me access to your repo if not? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
ohhhh you opened a PR from briganti's repo - in that case nvm, i don't think this can be updated at all, so i'll just close it (i'd also never have been able to land it without briganti's cooperation anyways; please don't open PRs from repos that aren't yours)
Fixes #74
See https://github.com/airbnb/babel-plugin-inline-react-svg/pull/77#issuecomment-931439820
@briganti this is your change, i'm just submitting it to hopefully get the ball rolling.