Closed akellbl4 closed 1 year ago
@akellbl4 the only other thing this needs is the "restricted branches" setting changed to no longer require travis, which requires an @airbnb employee to change.
Once this lands, the actions will run, after which the restricted branch settings can add the actions it should thenceforth require.
Rebased; this is now good to go. No need for further changes until an admin is able to fix the protected branch settings, at which point i'll merge this :-)
Hey @ljharb, how can we ping anyone from @airbnb to take a look on it? :)
I’ve already done so; all we can do now is wait.
@ljharb I've added some of the new checks as required in the branch restriction settings, but I seem to be missing a node one that we've done elsewhere.
Do you happen to know what I should be searching for here? Is it posttest?
@lencioni there should be posttest
, as well as two node ones, but they won't show up in the autocomplete unless they've run recently, and this PR ran months ago :-) the merge into master, however, will populate the dropdown soon so you can add them.
The node ones are not showing up. I had done #119 in hopes that it would trigger it, but it seems to not have. In any case, I added posttest now.
ah, try "latest majors"
That gives me a check for each version, unfortunately
hm, you're right. i'll make a PR to fix it.
Thanks! I added that one to the settings now, so I think we can call this a wrap
@lencioni one more thing :-) can we remove the review requirement? i need to be able to push things without a PR to release properly.
@ljharb agreed, that is super annoying for releasing. I think I've updated the settings now.
Thanks! The only thing left is that the automatic rebase and allow edits checks only run on a PR :-/ so either we can make those optional, or, add me to the airbnb org with a custom role that allows me to bypass branch protections (which i assume is a bit more difficult, bureaucratically)
I have made those optional now too. I think that's fine since making them required is unlikely to matter all that much anyway.
Much obliged, and I agree.
Implements CI jobs with Github Actions Passed actions on my fork