search

airbnb / babel-plugin-inline-react-svg

A babel plugin that optimizes and inlines SVGs for your React Components.
MIT License
474 stars 92 forks source link

Register export declaration in scope #77

Closed oleg-rdk closed 1 year ago

oleg-rdk commented 4 years ago

Fixes #74

pushred commented 3 years ago

@oleg-rdk do you plan to revisit this PR? The warning is super annoying =)

ljharb commented 3 years ago

If not, someone who wants it to land can post a link (not a new PR) to a branch or commit that rebases and accounts for review comments, and I’ll pull it into this PR.

briganti commented 2 years ago

@ljharb I have pulled @oleg-rdk's branch, rebase it on master and tackle your comments: https://github.com/briganti/babel-plugin-inline-react-svg/commits/fix-declaration-warning

let me know if you need anything, I too need this PR released 🙂

briganti commented 2 years ago

@lencioni sorry to drag you in this, but I've noticed you also have contributed to this project. is there anything you can do to make this fix merged? I would really appreciate it.

ljharb commented 2 years ago

@briganti I haven't gotten to it yet, is all, but will do so soon.

merlindru commented 2 years ago

Would be happy to contribute to this as well! Anything I can do to help this get landed?

simleb commented 2 years ago

👋 I'm happy to help too but it seems @briganti's branch is still as ready as ever. So this is just a friendly reminder about this PR that I'd also like to see merged! 😃

ljharb commented 2 years ago

This PR is now good to go on its own, but is blocked for the same reason as https://github.com/airbnb/babel-plugin-inline-react-svg/pull/116#issuecomment-1235882184.

simleb commented 1 year ago

@ljharb is this (and https://github.com/airbnb/babel-plugin-inline-react-svg/pull/116) unblocked now that https://github.com/airbnb/babel-plugin-inline-react-svg/pull/117 merged?

simleb commented 1 year ago

@ljharb sorry to keep bugging you but would it be possible to tag a new version now that a few PRs (including this one) have been merged?

ljharb commented 1 year ago

@simleb i just got permissions sorted out yesterday so that i can release; i'll try to do that in the next couple days.

ljharb commented 1 year ago

v2.0.2 is released.