fixing bug with applying policy to optional resource

airbnb / binaryalert

BinaryAlert: Serverless, Real-time & Retroactive Malware Detection.

https://binaryalert.io

Apache License 2.0

1.41k stars 187 forks source link

fixing bug with applying policy to optional resource #141

Closed ryandeivert closed 5 years ago

ryandeivert commented 5 years ago

to: @Ryxias cc: @airbnb/binaryalert-maintainers

Background

I hadn't realized the logging bucket was optional, and applying a policy to a non-existent optional resource will fail.

Changes

Making bucket policy optional for the logging bucket (will only get applied if the resource also exists).

coveralls commented 5 years ago

Coverage remained the same at 92.2% when pulling 2ee0a903242632594628872015faf51e25a6923a on ryandeivert-fix-bug-with-optional-resource into af5237484ee3cd420fd1a59c5db997265ba30d2d on master.