Update IAM Group Terraform configuration file

airbnb / binaryalert

BinaryAlert: Serverless, Real-time & Retroactive Malware Detection.

https://binaryalert.io

Apache License 2.0

1.41k stars 187 forks source link

Update IAM Group Terraform configuration file #142

Closed mmwtsn closed 2 years ago

mmwtsn commented 5 years ago

to: @airbnb/binaryalert-maintainers size: small

Background

This notes the available environment variables in the IAM Group Terraform file.

Changes

Minor documentation update pulled from the Terraform AWS Provider docs

Testing

This was tested by copying and pasting the Terraform file from the docs and running it locally.

coveralls commented 5 years ago

Coverage remained the same at 92.2% when pulling de18ecf0951e725591f827c53db8e2dc3666065c on capsule8:iam-group-tf-update into 3ad4d89b7bd7978d74e25a28e6c4c833f324d752 on airbnb:master.

ryandeivert commented 5 years ago

@mmwtsn I could be missing something, but this appears to only update docs.. not actual TF code?

mmwtsn commented 5 years ago

@ryandeivert correct. This file is only in the docs as far as I've seen. Creating the IAM Group with this file the first step you see when you start the Getting Started guide. I think this should be rolled into the CLI so users can get started without copying and pasting this file from the docs but I figured until then this was useful. If you're on board with that I can look into making the CLI update after this is reviewed.

mmwtsn commented 5 years ago

Updated address @austinbyers's feedback in https://github.com/airbnb/binaryalert/pull/142#pullrequestreview-212583097.

mmwtsn commented 5 years ago

Assuming the RST syntax in here is correct this should be ready.