airbnb / binaryalert

BinaryAlert: Serverless, Real-time & Retroactive Malware Detection.
https://binaryalert.io
Apache License 2.0
1.39k stars 187 forks source link

Cloudwatch Alarm Statistic for downloader_sqs_age #158

Open hammadzz opened 4 years ago

hammadzz commented 4 years ago

https://github.com/airbnb/binaryalert/blob/a9c0f06affc35e1f8e45bb77f835b92350c68a0b/terraform/cloudwatch_metric_alarm.tf#L82-L83

I am a bit baffled. This alarm is to catch a message age before it hits 75% of the retention time. In such a case why is the statistic set to minimum rather than maximum?

This would mean that the minimum of the oldest message would be checked instead of the maximum of the oldest message. Also the evaluation_periods of 10 seems rather generous.