airbnb / binaryalert

BinaryAlert: Serverless, Real-time & Retroactive Malware Detection.
https://binaryalert.io
Apache License 2.0
1.41k stars 187 forks source link

Fixed cve_rules folder name according to latest Yara-Rule repo structure #159

Open sunilrebel opened 4 years ago

sunilrebel commented 4 years ago

to: @airbnb/binaryalert-maintainers cc: size: small|medium|large resolves #

Background

Yara rules were not fetched from the defined folder because the repo structure changed and folder were renamed.

Changes

Testing

Tested on my local system. Screenshot attached.

image

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 90.52% when pulling 8f2bbb0d3010f546557549a175be2e9cbcef9b98 on sunilrebel:master into a9c0f06affc35e1f8e45bb77f835b92350c68a0b on airbnb:master.

sunilrebel commented 4 years ago

What I have to do to increase the coverage? It is a folder name change which is used while cloning rules

jdheyburn commented 4 years ago

Any chance this can get merged? New builds of the project are missing out on these yara rules.