airbnb / chronon

Chronon is a data platform for serving for AI/ML applications.
Apache License 2.0
717 stars 44 forks source link

Fix thread safety issue in consistency pipeline #775

Open jbrooks-stripe opened 3 months ago

jbrooks-stripe commented 3 months ago

Summary

This changes things such that a new instance of the AvroCodec is used instead of re-using the same one across requests.

Why / Goal

To log feature values for the consistency pipeline, we use AvroCodec to encode and hash keys, but the Avro encoding here is not thread safe.

Test Plan

Checklist

Reviewers

hzding621 commented 1 day ago

Ah missed this, I will fix it in https://github.com/airbnb/chronon/pull/857!