airbnb / chronon

Chronon is a data platform for serving for AI/ML applications.
Apache License 2.0
717 stars 44 forks source link

fix: Update derivation response map to pass through base exceptions #779

Closed hzding621 closed 3 months ago

hzding621 commented 3 months ago

Summary

One of the UTs of FetcherTest is failing on main branch. The RC is that we updated fetcher response map logic when there is failure in derivations.

This PR updated the logic to pass through the base exceptions. Base map fetching failure will guarantee failure of derivation because some fields are missing, so passing through the base exception is important to keep trace of the original issue. Also the UT is updated to match the new behavior.

Why / Goal

Fix a UT on main branch, and properly handle exception logging in response map.

Test Plan

Checklist

Reviewers

@pengyu-hou @yuli-han @donghanz