Closed hzding621 closed 2 months ago
Hi @hzding621 my understanding on this is: we want to provide a way for users to update topic without triggering the archive. Could you clarify what is the new workflow if users want to update the topic without triggering an archive? Do they need to set the exclude_topic flag in hive table and update the topic at the same time? Also when we load the old semantic hash how do we avoid the diff with new hash when the topic is updated and exclude_topic flag is set? I am confused of this line. Should we perform an archive or not here?
[auto archive] if exclude_topic did exist, we perform auto archive as usual
Summary
This PR removes topic (including both EventSource.topic, and EntitySource.mutationTopic) from the calculation logic of semantic_hash during offline join backfill logic.
detailed logic
migration plan
Why / Goal
Test Plan
Integration Test Plan
✅ test case 1 (also in UT):
✅ test case 2:
✅ test case 3 (also in UT):
✅ test case 4:
Reviewers
@donghanz @yuli-han @pengyu-hou