Adding a new logErrorSamplePercent param to metadata

airbnb / chronon

Chronon is a data platform for serving for AI/ML applications.

Apache License 2.0

746 stars 53 forks source link

Adding a new logErrorSamplePercent param to metadata #852

Closed pengyu-hou closed 1 month ago

pengyu-hou commented 1 month ago

Summary

This PR will separate the log sample rate and log error sample rate to spamming the logs.

Why / Goal

Test Plan

[ ] Added Unit Tests
[x] Covered by existing CI
[ ] Integration tested

Checklist

[ ] Documentation update

Reviewers

@airbnb/zipline-maintainers

hzding621 commented 1 month ago

Discussed offline and we will figure out a local workaround to unblock testing. In terms of configuring log sampling rate, let's try a more generic approach

pengyu-hou commented 1 month ago

close this PR to avoid adding new param to metadata for now.

pengyu-hou commented 1 month ago

Discussed offline and we will figure out a local workaround to unblock testing. In terms of configuring log sampling rate, let's try a more generic approach

yup, @hzding621 , I closed this PR.