Refine UIKit to SwiftUI Measurement Strategies - Githubissues

airbnb / epoxy-ios

Epoxy is a suite of declarative UI APIs for building UIKit applications in Swift

Apache License 2.0

1.24k stars 76 forks source link

Refine UIKit to SwiftUI Measurement Strategies #162

Closed brynbodayle closed 8 months ago

brynbodayle commented 9 months ago

Change summary

fixes an issue when sizing bridged UILabel's to SwiftUI where the view would always take up the proposed size
refactors sizing strategies for simplification and reducing unnecessary measurement
added sizing strategies demo code

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

[ ] Wrote automated tests
[x] Built and ran on the iOS simulator
[ ] Built and ran on a device

Simulator Screen Recording - iPhone 6s - 2024-02-15 at 14 29 48

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

[ ] Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
[x] Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

brynbodayle commented 8 months ago

This is ready for review now. Happo diffs look more correct when testing in the Airbnb app.