airbnb / gosal

A Sal client written in Go
Apache License 2.0
35 stars 21 forks source link

Reporting Disk information doesn't always return C: #11

Closed bdemetris closed 7 years ago

bdemetris commented 7 years ago

Gosal needs to handle the disk array returned from win32_localdisk better.

currently it assumes that the index 1 https://github.com/airbnb/gosal/blob/master/reports/builder.go#L25 is the disk that we want to send. Depending on the windows install, disk 1 could be the DVD drive, or some other drive. We need to detect C: in a dynamic way, and always return that to Sal's base report.