fix: render_batch receives jobs in hash form.

airbnb / hypernova-ruby

Ruby client for Hypernova.

https://github.com/airbnb/hypernova

MIT License

141 stars 55 forks source link

fix: render_batch receives jobs in hash form. #21

Closed 0xdiba closed 5 years ago

0xdiba commented 5 years ago

All occurrences of RequestService's render_batch receive their jobs input in hash form but were expecting it to be an array. This caused the on_error callbacks to always silently get called with a nil job.

Since the consistent form of arguments to the RequestService's methods is a hash, the mock jobs in its test are also wrapped in a hash ( instead of an array ).

0xdiba commented 5 years ago

Gentle ping :smiley: @ljharb @goatslacker

agis commented 5 years ago

@ljharb @goatslacker Any chance this is going to get merged soon? Asking to decide if should fork hypernova-ruby or not. Thanks!

agis commented 5 years ago

@goatslacker Thanks a lot! I guess the next question is 😊 ... any chance you'll get out a new release?

goatslacker commented 5 years ago

Released as 1.4.0

https://rubygems.org/gems/hypernova/versions/1.4.0