Closed mindera-zecarlos closed 6 years ago
I rebased (not sure if this is what you were looking for) but Travis seems to have a sporadic failure.
@stoikerty a rebase would leave behind no merge commits; but it's fine if you'd prefer one of us to take care of it for you. Don't mind the travis failure - i've reran it - they've been having some issues with job timeouts.
Yes please. That would be nice, thanks!
Rebased; waiting on reviews from other collabs.
Hey @ljharb
I know you're always mightily busy going through all these open-source repos and it's much appreciated, I know you make the rounds a lot, so sorry to be a pain. As we're progressing with the use of hypernova internally, we wanted to ask if there is an update on this PR / if there is anything we or you can do do get this in?
@stoikerty i'll ping some folks to see about getting another review
woop woop 🎉 thanks guys! 😄
In our project, we need to add more middlewares than just the logger to express. Hypernova starts the server automatically and returns an express instance already initialized and we cannot add middlewares afterwords.
If we can pass the instance of express and prevent hypernova to create a new one, then we have more control over additional features to express (and maybe this is useful for other people as well). By default, if we don't pass any express instance, then hypernova will create and handle it.