search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 207 forks source link

Update README.md: remove chinese quotation marks #143

Closed huijian3139 closed 5 years ago

huijian3139 commented 5 years ago

There are lot of quotation marks ‘ or ’ inside the codebase, this PR removes those inside README.md.

huijian3139 commented 5 years ago

Hah，interesting, closing this PR.

huijian3139 commented 5 years ago

Hi @ljharb, thanks for pointing that out. But I think there still exist some incorrectness. I have updated the curly quotation masks. For example, user‘s should be user’s. What do you say? https://practicaltypography.com/straight-and-curly-quotes.html

ljharb commented 5 years ago

@huijian3139 that very article contains the phrase "There­fore, straight quotes should never, ever ap­pear in your documents.". A straight quote is never correct in English.