search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 207 forks source link

worker: Change graceful shutdown exit code #148

Closed kpelelis closed 5 years ago

kpelelis commented 5 years ago

Hello. Once the PR adding graceful shutdown (#147), we noticed that the default exit code is non-zero and can affect some external systems.

Since the shutdown is graceful, it makes sense to exit the process with 0 instead of the default value (currently 1). This will help process management software (e.g. systemd) identify that the process exited normally.

In a side note, we could re-iterate the default exit code of shutDownSequence as 0 would make more sense. I can update my patch to reflect this changes.

agis commented 5 years ago

@ljharb Are there any plans for a new release soon? Asking to decide if we want to cut our own version with these last two patches. Happy new year!

ljharb commented 5 years ago

v2.5.0 is released.