Ruby version in example is ambiguous

airbnb / hypernova

A service for server-side rendering your JavaScript views

MIT License

5.82k stars 207 forks source link

Ruby version in example is ambiguous #150

Closed alexsbryan closed 4 years ago

alexsbryan commented 5 years ago

Appreciate the work on the project! I had ruby 2.5.x running on my system and couldn't get the example to run on account of what seemed like this issue: https://github.com/rails/rails/issues/27670 (Fixnum is deprecated error). After installing 2.3.8 it worked well enough to test, but there were some odd errors in the server logs.

I'd like to request that the ruby version be specified in the Gemfile for anyone who might run into this in the future.

ljharb commented 5 years ago

Sure, a PR to add that would be great.

marconi1992 commented 4 years ago

@ljharb I think this issue is solved by the merged PR above.

ljharb commented 4 years ago

Closed in #151.