search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 211 forks source link

Add an updated example that works with Ruby 2.6.8 #189

Open csharplus opened 2 years ago

csharplus commented 2 years ago

The current example 'simple' does not work with the latest version Ruby 2.6.8.

csharplus commented 2 years ago

@ljharb could you please review this PR?

csharplus commented 2 years ago

@lencioni could you please review and stamp this PR, thanks.

ljharb commented 2 years ago

It seems reasonable, but i haven’t had time to check out and run the example app. it hasn’t even been 2 weeks; what’s the rush?

csharplus commented 2 years ago

It seems reasonable, but i haven’t had time to check out and run the example app. it hasn’t even been 2 weeks; what’s the rush?

Sure, it is not urgent. Please review it at your earliest convenience, thanks.