airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 211 forks source link

update deps, fix linting, add nodes to testing matrix; migrate tests to github actions #190

Closed duoertai closed 2 years ago

duoertai commented 2 years ago

@csharplus

ljharb commented 2 years ago

What’s the point of this?

ljharb commented 2 years ago

Migrated to github actions, latest results are here: https://github.com/duoertai/hypernova/actions

@lencioni can you remove travis-ci from the required branch protections? then i can land this, and after that, we can make the actions status checks required.

ljharb commented 2 years ago

Thanks! Once the first three jobs on https://github.com/airbnb/hypernova/actions are completed, they can be added as required checks.

lencioni commented 2 years ago

I think we actually need 4 here. Does this look right to you?

image
ljharb commented 2 years ago

It's missing pretest and posttest, but otherwise yep!

lencioni commented 2 years ago

pretest and posttest are now added. thanks!