search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

fix README #193

Open duoertai opened 2 years ago

ljharb commented 2 years ago

I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?

duoertai commented 2 years ago

I’m not sure how this is a fix - is this perhaps correct for a different version of ruby/rails?

resubmitting https://github.com/airbnb/hypernova/pull/169/files

duoertai commented 2 years ago

@ljharb should we just remove v4 and v5 tests? seems it doesn't support destructuring and introduce 'unexpected token ...' error

ljharb commented 2 years ago

No, first we should fix them. We should be able to use any syntax if we have Babel set up right.

ljharb commented 2 years ago

Please don’t “resubmit” PRs; old ones can and should be reused. Every PR is a permanent ref on the repo, and creating duplicates just pollutes things.

ljharb commented 2 years ago

I think maybe updating the Airbnb preset is probably a better bet

duoertai commented 2 years ago

I think maybe updating the Airbnb preset is probably a better bet

OK. But after adding the plugin, it's working on my local with node v5, not sure why the test is still failing in github

duoertai commented 2 years ago

@ljharb is the babel version setup in uses: ljharb/actions/.github/workflows/node.yml@main ? not sure how to proceed

ljharb commented 1 year ago

if this is left open, then someone else can pick it up.