search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

missing `.finally()` #201

Closed espretto closed 1 year ago

espretto commented 1 year ago

Hi, This is a problem.

https://github.com/airbnb/hypernova/blob/3d7609ad6cc69e42993c7544534cab9f9ce599ac/src/environment.js#L5

ljharb commented 1 year ago

It's called "es6 methods" and finally isn't in ES6, but I agree that finally should be added to that list. es6StaticMethods is also missing allSettled and any.

A better fix, though, is removing use of Bluebird entirely.

espretto commented 1 year ago

duplicate of #183