search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

Make number of CPUs configurable #57

Closed magicmark closed 7 years ago

magicmark commented 7 years ago

This branch adds a cpu config option, to cap the number of workers Hypernova spawns

(This is desirable in deployments where we'd like to control the number of cpus per container)

Thanks!

ljharb commented 7 years ago

@magicmark thanks! I'm going to wait for @goatslacker to review this, and it'd be good in the meantime to rebase this (to remove "typo fix" style commits, and all merge commits), but otherwise this is great :-)

magicmark commented 7 years ago

Rebased to make one commit.

dadowns commented 7 years ago

Looks like you need another rebase. I was going to write this last week and then noticed your PR, nice! I am very eager to see this released as I need to cap max workers before getting to prod.

magicmark commented 7 years ago

Pinging @goatslacker for review :)

ljharb commented 7 years ago

@magicmark please rebase on the command line; the "update" button on the github UI creates a merge commit.

magicmark commented 7 years ago

@ljharb @goatslacker Rebased again to make one commit :)

Will-Sommers commented 7 years ago

Hey y'all! Thank you for this one, we've been following this one for a while at Rent the Runway.

goatslacker commented 7 years ago

I'll put out a release and fix the changelog in a minute. I'd like to merge some of the other PRs as well.