search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

Adding sourcemaps for coverage reports #61

Open magicmark opened 7 years ago

magicmark commented 7 years ago

html coverage reports currently show the compiled es5

Would be nice to either:

  1. Add sourcemaps to istanbul reports
  2. Switch to nyc and compile on the fly

(2 is maybe undesirable if you want the assurance of testing against the actual dist code. fwiw though, something like this patch does the trick.)

ljharb commented 7 years ago

If you'd like to submit a PR switching us to nyc, I think that'd be great.

magicmark commented 7 years ago

https://github.com/airbnb/hypernova/pull/63