search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

I'd like to be able to add my own log transports #64

Closed morganpackard closed 6 years ago

morganpackard commented 7 years ago

I see that I have the ability to add a logger property to the config object passed in to the hypernova initializer. However, it looks like this only gives me the ability to override these defaults:

{
  level: 'info',
  colorize: true,
  timestamp: true,
  prettyPrint: process.env.NODE_ENV !== 'production',
}

What I'd really like to be able to do is pass in my own transports to Winston so I can hook in to my remote logging service. Any plans to add this feature?

goatslacker commented 7 years ago

We can probably add a transports key to the config object. PR's welcome.

morganpackard commented 7 years ago

Thanks!

wingleung commented 6 years ago

@goatslacker so, did this happen already? I can't get any logging from my setup.

wingleung commented 6 years ago

gave a try, feedback is welcome -> airbnb/hypernova#117

wingleung commented 6 years ago

just saw a PR from a couple of months ago -> https://github.com/airbnb/hypernova/pull/104 so my PR might be obsolete https://github.com/airbnb/hypernova/pull/117

schleyfox commented 6 years ago

Fixed in https://www.npmjs.com/package/hypernova/v/2.2.6 . Thanks everyone!