search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

HTTP status code is not set #83

Closed magicmark closed 7 years ago

magicmark commented 7 years ago

In trying to add some logging middleware, I noticed that res.statusCode is not set.

(curl: http://i.imgur.com/Ch5f2gM.png)

I presume this is an unintended bug? Looks like status is set here: https://github.com/airbnb/hypernova/blob/master/src/utils/renderBatch.js#L20

magicmark commented 7 years ago

Ah, just read this, looks like this is intentional. (I guess since it's only 1 component in the batch that errored, others could succeed).

Closing.