search

airbnb / hypernova

A service for server-side rendering your JavaScript views
MIT License
5.82k stars 208 forks source link

An in-range update of eslint is breaking the build 🚨 #96

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 6 years ago

Version 4.10.0 of eslint was just published.

Branch Build failing 🚨
Dependency eslint
Current Version 4.9.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/airbnb/hypernova/builds/293946416?utm_source=github_status&utm_medium=notification)
Release Notes v4.10.0
  • bb6e60a Fix: Improve the doc for no-restricted-modules rule (fixes #9437) (#9495) (vibss2397)
  • c529de9 Docs: Amend rule document to correct and complete it (refs #6251). (#9498) (Jonathan Pool)
  • f9c6673 Chore: Add tests to cover array and object values and leading commas. (#9502) (Jonathan Pool)
  • 9169258 Chore: remove npm run check-commit script (#9513) (Teddy Katz)
  • 7d390b2 Docs: Revise contributor documentation on issue labels. (#9469) (Jonathan Pool)
  • d80b9d0 Fix: no-var don't fix globals (fixes #9520) (#9525) (Toru Nagashima)
  • b8aa071 Fix: allow linting the empty string from stdin (fixes #9515) (#9517) (Teddy Katz)
  • 350a72c Chore: regex.test => string.startsWith (#9518) (薛定谔的猫)
  • de0bef4 Chore: remove obsolete eslintbot templates (#9512) (Teddy Katz)
  • 720b6d5 Docs: Update ISSUE_TEMPLATE.md (#9504) (薛定谔的猫)
  • 2fa64b7 Fix: should not convert non-consecutive line comments to a single blo… (#9475) (薛定谔的猫)
  • 9725146 Fix: multiline-comment-style fix produces invalid code (fixes #9461). (#9463) (薛定谔的猫)
  • b12cff8 Fix: Expected order of jsdoc tags (fixes #9412) (#9451) (Orlando Wenzinger)
  • f054ab5 Docs: add .md to link (for github users) (#9501) (薛定谔的猫)
  • 5ed9cfc Docs: Correct violations of “Variable Declarations” in Code Conventions (#9447) (Jonathan Pool)
  • 3171097 Docs: Clears confusion on usage of global and local plugins.(#9492) (Vasili Sviridov)
  • 3204773 Chore: enable max-len. (#9414) (薛定谔的猫)
  • 0f71fef Docs: Unquote booleans in lines-between-class-members docs (#9497) (Brandon Mills)
  • b3d7532 Docs: use consistent terminology & fix link etc. (#9490) (薛定谔的猫)
  • 87db8ae Docs: Fix broken links (#9488) (gpiress)
  • 51bdb2f Docs: Incorrect link to related rule (#9477) (Gavin King)
  • 1a962e8 Docs: Add FAQ for when ESLint cannot find plugin (#9467) (Kevin Partington)
  • 8768b2d Fix: multiline-comment-style autofixer added trailing space (#9454) (Teddy Katz)
  • e830aa1 Fix: multiline-comment-style reports block comments followed by code (#9450) (Teddy Katz)
  • b12e5fe Docs: Repair broken links and add migration links. (#9473) (Jonathan Pool)
  • eca01ed Docs: Add missing info about special status of home-dir config files. (#9472) (Jonathan Pool)
  • eb8cfb1 Fix: change err report in constant condition (fixes #9398) (#9436) (Victor Hom)
  • da77eb4 Chore: Revise no-config-file test to prevent false failure. (#9443) (Jonathan Pool)
  • 47e5f6f Docs: ensure "good commit message" examples actually follow guidelines (#9466) (Teddy Katz)
  • ebb530d Update: Don't ignore comments (no-trailing-spaces) (#9416) (Chris van Marle)
  • 5012661 Build: fix npm run profile script (fixes #9397) (#9455) (Teddy Katz)
  • ecac0fd Docs: Remove blockBindings references (#9446) (Jan Pilzer)
  • 0b89865 Chore: ensure tests for internal rules get run (#9453) (Teddy Katz)
  • 052c504 Docs: suggest deleting branches after merging PRs (#9449) (Teddy Katz)
  • b31e55a Chore: move internal rules out of lib/ (#9448) (Teddy Katz)
  • a7521e3 Docs: improve examples for multiline-comment-style (#9440) (Teddy Katz)
Commits

The new version differs by 38 commits.

  • 9deb1b1 4.10.0
  • 6d19001 Build: changelog update for 4.10.0
  • bb6e60a Fix: Improve the doc for no-restricted-modules rule (fixes #9437) (#9495)
  • c529de9 Docs: Amend rule document to correct and complete it (refs #6251). (#9498)
  • f9c6673 Chore: Add tests to cover array and object values and leading commas. (#9502)
  • 9169258 Chore: remove npm run check-commit script (#9513)
  • 7d390b2 Docs: Revise contributor documentation on issue labels. (#9469)
  • d80b9d0 Fix: no-var don't fix globals (fixes #9520) (#9525)
  • b8aa071 Fix: allow linting the empty string from stdin (fixes #9515) (#9517)
  • 350a72c Chore: regex.test => string.startsWith (#9518)
  • de0bef4 Chore: remove obsolete eslintbot templates (#9512)
  • 720b6d5 Docs: Update ISSUE_TEMPLATE.md (#9504)
  • 2fa64b7 Fix: should not convert non-consecutive line comments to a single blo… (#9475)
  • 9725146 Fix: multiline-comment-style fix produces invalid code (fixes #9461). (#9463)
  • b12cff8 Fix: Expected order of jsdoc tags (fixes #9412) (#9451)

There are 38 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 4.9.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

ljharb commented 6 years ago

Fixed in d599ac8c2a81d3cc83ed847cff378e7488b0fd08