search

airbnb / interferon

Signaling you about infrastructure or application issues
MIT License
239 stars 44 forks source link

Run the config file through ERB to pull secrets in from ENV #50

Open JKHiggins opened 6 years ago

JKHiggins commented 6 years ago

@jimmyngo I've rebased this on master and it's passing the build now.

jimmyngo commented 6 years ago

This is pretty straight forward, but what's the value of passing secrets through ENV versus putting it in the directly in the config?

JKHiggins commented 6 years ago

We don't encrypt our config file, so it would be insecure to commit them to the repo. We prefer using ENV for this, the secrets can still be put in the ENV directly if that's what you want to do, but this just enables you to be more secure with your secrets.

jimmyngo commented 6 years ago

There's a few new classes of errors that can occur when calling ERB.new with invalid syntax/usage. We should handle them all, or change the error handling to something more generic.