search

airbnb / interferon

Signaling you about infrastructure or application issues
MIT License
239 stars 44 forks source link

Add notification prevention if dry-run #53

Closed JKHiggins closed 6 years ago

JKHiggins commented 6 years ago

@jimmyngo we found another small change in our fork that's probably valuable for upstream :)

jimmyngo commented 6 years ago

Dry-run no longer creates alerts though?

JKHiggins commented 6 years ago

You're right, as it turns out this was an old enough change (we pulled it from way back in our fork as we were diffing against upstream master) that the datadog API changed out from under us and implemented a "validate" alert. Previously a dry-run would create and then delete the alert which would fire unnecessary notifications. I'll close this out as unnecessary :)